Nils Dagsson Moskopp
41550da87b
Fix redstone comparator flooding crash
...
Redstone comparators have two modes, comparison mode & subtraction mode.
Before this patch, the functions to turn comparators on or off attempted
to swap nodes with comparators in the same mode, but failed to determine
the correct replacement node, if the existing node was not a comparator.
When a comparator in an on state (e.g. powered by a filled cauldron) was
flooded, the flooding dropped the comparator and replaced the comparator
node that was to be swapped out with air, which lead to a server crash.
This patch changes the functions that turn comparators on or off so they
only swap existing nodes with comparators in the same mode if the name
of the replacement node can be determined – i.e. if it is not nil.
2022-02-24 15:52:01 +01:00
AFCMS
cbfc71705d
remove blender backup file
2022-02-24 10:16:47 +01:00
kabou
5431e206b0
Fix hopper breakage in get_item_group return value.
...
In commit 55009c257e
that added vectors to
mcl_composters, mcl_hoppers was accidentally patched with a unrelated
change, updating it to get_item_group(). This mostly works, but in one
particular case the semantics of the return value differs. Instead of
returning 'nil' it returns '0'. That altered the evaluation of an if
condition, breaking the abm that sucks in items.
This commit fixes the conditional by explicitly comparing '~= 0'.
2022-02-24 03:18:25 +01:00
Emojigit
06deb92dd6
mcl_tools
2022-02-23 23:58:05 +01:00
Emojigit
7685b4758f
mcl_flowers
2022-02-23 23:58:05 +01:00
Emojigit
9944abb328
mcl_books
2022-02-23 23:58:05 +01:00
Emojigit
5ce1852c1d
mcl_dye
2022-02-23 23:58:05 +01:00
Emojigit
56a70025b8
mcl_flowerpots
2022-02-23 23:58:05 +01:00
Emojigit
9fe3bbd2fa
mcl_mushrooms
2022-02-23 23:58:05 +01:00
Emojigit
fb1d189d40
mcl_doors
2022-02-23 23:58:05 +01:00
Emojigit
9cd24f4af5
mcl_commands
2022-02-23 23:58:05 +01:00
Emojigit
a64c3f87bc
xpanes
2022-02-23 23:58:05 +01:00
Emojigit
5075f2ca56
mcl_armor
2022-02-23 23:58:05 +01:00
Emojigit
249dfac319
mcl_inventory
2022-02-23 23:58:05 +01:00
Emojigit
2b5a0242db
mcl_fire
2022-02-23 23:58:05 +01:00
Emojigit
790ccf0812
mcl_fishing
2022-02-23 23:58:05 +01:00
Emojigit
8d639794f3
mcl_fences
2022-02-23 23:58:05 +01:00
Emojigit
af8681c143
mcl_buckets
2022-02-23 23:58:05 +01:00
Emojigit
1ef58f7250
mcl_walls
2022-02-23 23:58:05 +01:00
Emojigit
15747220f2
mcl_hoppers
2022-02-23 23:58:05 +01:00
Emojigit
925dad7f5e
mcl_anvils
2022-02-23 23:58:05 +01:00
Emojigit
729f653c85
mcl_portals
2022-02-23 23:58:05 +01:00
Emojigit
d1e328e57a
mcl_bows
2022-02-23 23:58:05 +01:00
Emojigit
615a968fbb
mcl_skins
2022-02-23 23:58:05 +01:00
Emojigit
7e5a9bd8b6
mcl_throwing
2022-02-23 23:58:05 +01:00
Emojigit
d018bee00a
mcl_cake
2022-02-23 23:58:05 +01:00
Emojigit
1365d0b257
mcl_jukebox
2022-02-23 23:58:05 +01:00
Emojigit
a289a00427
mcl_heads
2022-02-23 23:58:05 +01:00
Emojigit
a238aabbb0
mcl_cauldrons
2022-02-23 23:58:05 +01:00
Emojigit
b02f7cd974
mcl_mobs
2022-02-23 23:58:05 +01:00
Emojigit
e19113d4e0
findbiome
2022-02-23 23:58:05 +01:00
Emojigit
4deac632e6
mcl_sponges
2022-02-23 23:58:05 +01:00
Emojigit
c480e6891d
mcl_maps
2022-02-23 23:58:05 +01:00
Emojigit
844eb3fb7c
mcl_brewing
2022-02-23 23:58:05 +01:00
Emojigit
fc768cb1ad
mcl_signs
2022-02-23 23:58:05 +01:00
Emojigit
1f9a919459
mcl_monster_eggs
2022-02-23 23:58:05 +01:00
Emojigit
70007e3453
mcl_furnaces
2022-02-23 23:58:05 +01:00
Emojigit
3aff1f8981
mcl_hunger
2022-02-23 23:58:05 +01:00
Emojigit
c86a506672
mcl_tnt
2022-02-23 23:58:05 +01:00
Emojigit
f348223da2
mcl_crafting_table
2022-02-23 23:58:05 +01:00
Emojigit
ca6469b959
mcl_weather
2022-02-23 23:58:05 +01:00
Emojigit
c52e09ddcd
mcl_structures
2022-02-23 23:58:05 +01:00
Emojigit
bb55120adc
mcl_experience
2022-02-23 23:58:05 +01:00
Emojigit
77339afbe2
mcl_cocoas
2022-02-23 23:58:05 +01:00
Emojigit
9b15599bee
hudbars
2022-02-23 23:58:05 +01:00
Emojigit
a685c3bc83
mclx_core
2022-02-23 23:58:05 +01:00
Emojigit
b01d4eba88
mcl_paintings
2022-02-23 23:58:05 +01:00
Emojigit
952747d4da
mcl_mobspawners
2022-02-23 23:58:05 +01:00
Emojigit
430f5b05ab
mcl_itemframes
2022-02-23 23:58:05 +01:00
Emojigit
e4a311e28a
mcl_clock
2022-02-23 23:58:05 +01:00
Emojigit
6a115a68ef
mcl_armor_stand
2022-02-23 23:58:05 +01:00
Emojigit
f3d0ec845c
mcl_spawn
2022-02-23 23:58:05 +01:00
Emojigit
563daeed8a
mcl_wip
2022-02-23 23:58:05 +01:00
Emojigit
a6c3cab791
mclx_fences
2022-02-23 23:58:05 +01:00
Emojigit
bb4ddee570
mcl_compass
2022-02-23 23:58:05 +01:00
Emojigit
fe3e80bc0e
lightning
2022-02-23 23:58:05 +01:00
Emojigit
59fe078fd7
mcl_playerplus
2022-02-23 23:58:05 +01:00
Emojigit
dba08ddc1f
mcl_torches
2022-02-23 23:58:05 +01:00
Emojigit
551bf917e2
mcl_void_damage
2022-02-23 23:58:05 +01:00
Emojigit
26dadb1846
mcl_falling_nodes
2022-02-23 23:58:05 +01:00
Emojigit
33a353e20d
mcl_privs
2022-02-23 23:58:05 +01:00
Emojigit
f02f3c9f40
screwdriver
2022-02-23 23:58:05 +01:00
Emojigit
410c1ecd1f
mcl_hbarmor
2022-02-23 23:58:05 +01:00
Emojigit
ba172f0847
mcl_explosions
2022-02-23 23:58:05 +01:00
Emojigit
ad42c3588b
mcl_farming
2022-02-23 23:58:05 +01:00
Emojigit
9734c74c56
(WIP) mcl_farming
2022-02-23 23:58:05 +01:00
Emojigit
c3dd5e6c2c
MORE MESS SORRY XD
2022-02-23 23:58:05 +01:00
Emojigit
21808390f9
Revert "add translates for mcl_boats
"
...
This reverts commit 2ee84f2ad3bd1f067a43c9382d7fc70f30fab9f0.
2022-02-23 23:58:05 +01:00
Emojigit
cc87791327
add translates for mcl_boats
...
Co-authored-by: Emojigit <emojigit@noreply.git.minetest.land>
2022-02-23 23:58:04 +01:00
Emojigit
a8aabb2329
add translate for doc_identifier
2022-02-23 23:58:04 +01:00
Emojigit
4f00b62a18
add zh_TW translate to mcl_beds
and mcl_core
2022-02-23 23:58:04 +01:00
AFCMS
360a1604ba
Revert "move barrels to mcl_chests"
...
This reverts commit a272322cb5
.
2022-02-22 20:20:21 +01:00
AFCMS
61f4c5b885
apply @kay27 fix to mcl_util.drop_items_from_meta_container
2022-02-22 18:08:26 +01:00
AFCMS
a272322cb5
move barrels to mcl_chests
2022-02-22 18:08:25 +01:00
AFCMS
9112915ddd
fix barrel top texture rotation
2022-02-22 18:08:25 +01:00
AFCMS
397c243e89
cleanup barrel TODO list
2022-02-22 18:08:25 +01:00
AFCMS
c64d0e4558
simplify random dropping position code
2022-02-22 18:08:24 +01:00
AFCMS
61e54ed617
rename mcl_util.drop_items_container_get
to drop_items_from_meta_container
2022-02-22 18:08:24 +01:00
AFCMS
0988637ea1
add barrel tooltip help text
2022-02-22 18:08:24 +01:00
AFCMS
b88060dbfb
add doc description to barrels
2022-02-22 18:08:23 +01:00
AFCMS
e3e06b4a4b
fix broken tree placement
2022-02-22 18:08:23 +01:00
AFCMS
34b445b04a
fixes
2022-02-22 18:08:22 +01:00
AFCMS
d41a836514
add craft
2022-02-22 18:08:22 +01:00
AFCMS
80fb59f9ac
add barrel
2022-02-22 18:08:22 +01:00
cora
a9357f7380
Do not send redundant bone position and properties
2022-02-22 11:15:56 +00:00
kabou
af132cc523
Reinstate nil check in on_place_bucket.
...
* Oops, nil checks on registered_node[name] were erroneously optimized
away, risking crashes. Reinstate those checks.
2022-02-21 18:00:56 +01:00
kabou
e54502edd6
Add more local aliases for minetest.* namespace functions
...
* Add locals for
- minetest.is_creative_enabled
- minetest.is_protected
- minetest.record_protection_violation
2022-02-20 20:24:55 +01:00
kabou
639bf936c5
Use alias for minetest.* namespace function call.
...
* Fix one missed minetest.get_node use in earlier commit.
2022-02-20 19:52:05 +01:00
kabou
d2261426c3
Remove redundant variables in on_place_bucket.
...
The function on_place_bucket defined a couple of variables that were
used only once or in a redundant check. After removal of the redundant
check in a previous commit, all use-once variables can now be substituted
with their assignment expressions.
2022-02-20 18:46:23 +01:00
kabou
88ce1e3662
Remove redundant logic.
...
The function on_place_bucket contains the following logic:
if not a and not b then return x end
if a then
foo(a)
elseif b then
foo(b)
else
return x
end
The "if not a and not b then .." is removed because the case is handled
by the else case later on. This will allow some further simplifications.
2022-02-20 18:46:23 +01:00
kabou
b3aed9d6b8
Use proper get_item_group accessor.
...
Instead of directly accessing the group table in node definitions, use
the proper minetest.get_item_group accessor to test for "cauldron"
group.
Also adds local alias get_item_group for the global minetest call.
2022-02-20 18:46:23 +01:00
kabou
13baa68b67
Fixed missed alias uses and added set_node alias.
...
Two instances of add_node and add_item still used the full minetest
call, substitute the alias.
Added a set_node alias for several minetest.set_node calls.
2022-02-20 18:46:23 +01:00
kabou
315f251584
Add local to speedup global function access.
...
The minetest.registered_nodes function is called from multiple places.
Define a local alias registered_nodes and substitute it in all calls.
2022-02-20 18:46:23 +01:00
kabou
584a75df76
Fix filling cauldrons with water.
...
When using a bucket of water on a cauldron, this would not fill the
cauldron as expected, but deposit a water source block on top of the
cauldron instead.
Applied patch from mineclone5 #38 (commit #
698c29733f06a7fcb7e755bf26ee46b33b00699b) from mineclone5 that fixes
this problem.
2022-02-20 18:46:23 +01:00
kabou
8d18ab8a7a
Optimize texture files.
...
* Texture files were optimized with 'optipng -o7 -zm9 -strip all' .
2022-02-19 21:18:01 +01:00
kabou
f81980da51
Fix hardness and blast resistance.
...
* Use correct MC values for hardness and blast resistance.
2022-02-19 21:18:01 +01:00
kabou
55009c257e
Use new vectors
...
* Use vector.new instead of xyz table.
2022-02-19 21:18:01 +01:00
kabou
51ca60c097
Change custom node attribute name.
...
* Rename _compost_level to _mcl_compost_level
2022-02-19 21:18:01 +01:00
kabou
f22baafaa6
Add player object check.
...
* Add one more check if player object is an actual player.
2022-02-19 21:18:01 +01:00
kabou
ffc2c94096
Add help alias
...
* Add help alias for the ready type composter
2022-02-19 21:18:01 +01:00
kabou
cea821b2fa
Comment fixes.
...
* Improve comments, some typo fixes.
2022-02-19 21:18:01 +01:00
kabou
64608f50f8
Update mod description and fix comment.
...
* Make mod description more descriptive.
* Minor comment tweak.
2022-02-19 21:18:01 +01:00
kabou
3257014e00
Add missing melon block.
...
* Add melon block to the compostabiles list.
2022-02-19 21:18:01 +01:00
kabou
06274518bf
Add player object check.
...
* Handle the case where a mob somehow "clicks" on a composter and we get
an invalid player object passed.
2022-02-19 21:18:01 +01:00
kabou
8d79d16531
Update mod deps.
...
* Add dpendency on mcl_dye for the bone meal particle spawner
2022-02-19 21:18:01 +01:00
kabou
1f7697b6f5
Typo fix.
...
* it's a spruceSapling (thanks NO11)
2022-02-19 21:18:01 +01:00
kabou
64203c38a6
Update documentation.
...
* Make a mention of the one second delay before composter readies.
2022-02-19 21:18:01 +01:00
kabou
4cf88abe4c
Fix composter item image.
...
* Less is more (thanks AFCMS)
2022-02-19 21:18:01 +01:00
kabou
df8576e77c
mcl_composters initial commit
...
Implements a composter block with crafting recipe, and some more
uncraftable blocks representing various stages of filling.
Adds a list of items that can be used with the composter and the chances
of these items adding a layer to the composter.
Implements methods to add compostable items to the composter, to update
the composter to various levels of compost and to harvest an item of
bone meal when the composter is ready.
Textures were taken from XSSheep/Nova_Wostra Pixel Perfection texture
pack.
2022-02-19 21:18:01 +01:00
NO11
c40c05f594
Exact MC behavior
2022-02-17 15:32:58 +00:00
NO11
8db28c1337
Update get_pointed_thing function
2022-02-17 15:30:41 +00:00
NO11
d46a96c43a
Merge branch 'master' into buckets+
2022-02-17 14:48:07 +00:00
NO11
3cfcd1355f
Add missing dependency
2022-02-17 14:42:01 +00:00
NO11
4707cd4526
Correct bucket behavior
2022-02-17 14:36:48 +00:00
NO11
ad99746d99
Add get_pointed_thing function
2022-02-17 14:35:51 +00:00
Nils Dagsson Moskopp
adf738854a
Fix mob-in-boat crash in Minetest 5.5-dev
...
In Minetest 5.4.1, calling get_player_control() on a mob returned the
empty string. Minetest commit 5eb45e1ea03c6104f007efec6dd9c351f310193d
changed this, so now calling get_player_control() on a mob returns nil.
As mcl_boats defines boats that can have a player or a mob as a driver,
code like the following crashes with a changed get_player_control() API:
local ctrl = driver:get_player_control()
if ctrl.sneak then
detach_object(driver, true)
end
Furthermore, once a world has crashed, joining it near a mob that is the
driver of a boat with such control code immediately crashes again.
When I reported this bug to Minetest, several Minetest core developers
stated that they disliked the old API and proposed other return values
for calling a mob's get_player_control() function – all different from
the empty string. Since I have some doubts that this bug will be fixed
in Minetest 5.5.0, boat code must take into account a nil return value.
Minetest issue: https://github.com/minetest/minetest/issues/11989
2022-02-15 11:17:01 +01:00
AFCMS
da4952a125
wip mcl_damage documentation
2022-02-13 21:31:04 +01:00
AFCMS
c59bea211d
fix some typos
2022-02-13 21:31:03 +01:00
AFCMS
5aa18d573e
document mcl_armor function (WIP)
2022-02-13 21:31:03 +01:00
AFCMS
13f8fd457c
document manual armor creation
2022-02-13 21:31:03 +01:00
AFCMS
2b820d7756
mcl_armor.register_set()
documentation
2022-02-13 21:31:02 +01:00
Elias Åström
4ca89cfcae
Update groupcaps_hash function to minetest.sha1
2022-02-12 20:08:03 +01:00
Elias Åström
a6c5c8a72a
Call update_groupcaps from load_enchantments
...
This avoids the need to call the function from on_enchant for unbreaking
and efficiency.
2022-02-12 19:43:01 +01:00
Elias Åström
d898b02c8b
Fix #1922
2022-02-12 19:43:01 +01:00
AFCMS
2690094a95
allow placement of lanterns on chains
2022-02-10 11:45:08 +01:00
AFCMS
23873f31f1
add french translation of mcl_lanterns
2022-02-09 22:19:24 +01:00
AFCMS
749d4f1a4b
add lanterns translation template
2022-02-09 22:15:44 +01:00
AFCMS
8817d51d64
minecraft like lanterns placement limitations
2022-02-09 22:11:50 +01:00
AFCMS
9b375aa9e8
attemp to fix lanterns placement
2022-02-09 18:19:46 +01:00
AFCMS
7fbdd71081
obtimize glass detail images
2022-02-09 12:21:28 +01:00
AFCMS
e138d998ef
walkover
fixes
2022-02-09 12:21:28 +01:00
AFCMS
9cc088c940
fix lantern light value to fit minetest limit
2022-02-08 23:00:45 +01:00
AFCMS
6572a8c908
add lanterns, crafts, placement mechanism, doc entries
2022-02-08 22:56:20 +01:00
AFCMS
ffa9d2d0fd
add basic chains and lantern model and API
2022-02-08 10:58:25 +01:00
epCode
9b881df465
Temporarily remove glitchy Elytra crash-damage
...
If you fly in certain directions with this damage system, you will die. also if you speed up too fast.
2022-01-06 21:55:01 +00:00
NO11
627c37cd97
Fix pumpkin hud
2022-01-02 12:37:20 +00:00
NO11
7cc7fb1331
Make removing of arrow entities also work with mobs, remove arrows on respawn
2022-01-02 11:06:29 +00:00
NO11
7b46225176
Remove arrow entities when the player joins to prevent killing on startup (working fix)
2022-01-01 22:59:21 +00:00
NO411
7b47a15e34
Remove arrow entities when the player leaves to prevent killing on startup
2021-12-30 14:04:53 +01:00
AFCMS
a7e471de62
framed stained glass
2021-12-23 18:02:43 +01:00
AFCMS
12830781f8
Merge branch 'master' into connected_glass
2021-12-23 17:29:53 +01:00
Elias Fleckenstein
bfd1fd69d1
Fix potential crash when falling onto unknown node
2021-12-19 18:59:09 +01:00
Elias Fleckenstein
e2360204a7
Revert "fixed daylightsensor's register_abms"
...
This reverts commit 5a4abcbcb7
.
2021-12-12 15:55:52 +01:00
chmodsayshello
5a4abcbcb7
fixed daylightsensor's register_abms
...
By changing the check if a normal/inverted daylightsensor should update by turning on and off, I made them workling again
2021-12-10 13:59:31 +00:00
kay27
0c8e5dc7a4
Disable Nether portal node rotation by screwdriver
2021-12-10 03:52:14 +04:00
Elias Fleckenstein
e4feb233e0
Fix hopper dupe
2021-12-09 18:20:24 +01:00
Elias Fleckenstein
b945975427
Slime splitting: nil check child to prevent crash (that happened on oysterity-mcl2)
2021-12-09 18:11:05 +01:00
Elias Fleckenstein
0e9a56fa35
Add stacks to enchant_uniform_randomly
2021-12-07 18:19:41 +01:00
Elias Fleckenstein
ec7e245b9d
Various fixes to the enchanting and loot system
...
- enchanted loot generated by mapgen now uses PseudoRandom for randomness
- prevent fishing loot from generating loot 32767 times (!!!) when only 1 is needed
- bows and fishing rods obtained from the treasure section of fishing loot are now enchanted
- there is now a function to uniform enchant items other than books
2021-12-07 17:57:18 +01:00
Elias Fleckenstein
b3958a956d
Refactor random enchantment selection code
2021-12-07 16:16:07 +01:00